Branch issue 8622: Remove python 2.7 - #9268
Closed
nsalwan wants to merge 4 commits into
Closed
Conversation
Member
|
@nsalwan Thanks for your contribution! I saw it sill use python2.7 somewhere in the cpp tests: @BewareMyPower Do you have some advice for that? |
Contributor
|
@zymap Maybe the |
Member
|
Yes, I think we need to remove all the python2 usage as possible as we can. |
Contributor
|
The PythonLibs and Boost.Python dependency that are found by CMake are still Python2 related stuff. The C++ tests CI environment is in image $ ls /usr/lib/x86_64-linux-gnu/libboost_python*.so
/usr/lib/x86_64-linux-gnu/libboost_python-py27.so /usr/lib/x86_64-linux-gnu/libboost_python.so
/usr/lib/x86_64-linux-gnu/libboost_python-py35.so
$ ls /usr/lib | grep python
python2.7
python3
python3.5 |
1 task
Contributor
|
The pr had no activity for 30 days, mark with Stale label. |
|
@nsalwan:Thanks for your contribution. For this PR, do we need to update docs? |
Contributor
|
Close it by #15376 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8622
Motivation
As per issue description : PIP-56 proposed we should upgrade our python version in the Docker image, we did that in the PR #7963.
But I still find some python2.7 usage in the pulsar repository.
We have fixed this issue.
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
getting rid of python 2.7
Modifications
Describe the modifications you've done.
Updated the CMake files.
Verifying this change
Yes, It does.
Documentation
It get rids of python 2.7 which is not supported by pulsar anyway.